Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct teams patterns use of multi-team namespace creation #1642

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

sylwit
Copy link
Contributor

@sylwit sylwit commented Jun 8, 2023

The readme says 2 namespaces team-blue and team-red will be created, but the code has some hardcoded values instead of using the key from the iterator

@sylwit sylwit requested a review from a team as a code owner June 8, 2023 12:12
@sylwit sylwit had a problem deploying to EKS Blueprints Test June 8, 2023 12:12 — with GitHub Actions Error
@sylwit sylwit changed the title fix: hardcoded variable fix: Hardcoded variable Jun 8, 2023
@sylwit sylwit had a problem deploying to EKS Blueprints Test June 8, 2023 12:22 — with GitHub Actions Failure
@bryantbiggs bryantbiggs changed the title fix: Hardcoded variable fix: Correct teams patterns use of multi-team namespace creation Jun 8, 2023
Copy link
Contributor

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@bryantbiggs bryantbiggs merged commit a7ec605 into aws-ia:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants